Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Entry IsSpellCheckEnabled property #7442

Merged
merged 17 commits into from
Mar 22, 2023
Merged

Implement Entry IsSpellCheckEnabled property #7442

merged 17 commits into from
Mar 22, 2023

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented May 24, 2022 •
edited by samhouts
Loading

Description of Change

Implement Entry IsSpellCheckEnabled property.

Fixes (but reverted) #8558

@jsuarezruiz jsuarezruiz added legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-entry Entry labels May 24, 2022
@rmarinho
Copy link
Member

@jsuarezruiz any idea why tests are failing ?

mattleibow
mattleibow approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the API breaks are gonna be fun.

@rmarinho
Copy link
Member

rmarinho commented Jun 2, 2022 

   D:\a\_work\1\s\src\Core\src\Core\ITextInput.cs(21,30): error RS0016: Symbol 'IsSpellCheckEnabled.get' is not part of the declared API [D:\a\_work\1\s\src\Core\src\Core.csproj]
         D:\a\_work\1\s\src\Core\src\Handlers\Entry\EntryHandler.Windows.cs(59,22): error RS0016: Symbol 'MapIsSpellCheckEnabled' is not part of the declared API [D:\a\_work\1\s\src\Core\src\Core.csproj]
         D:\a\_work\1\s\src\Core\src\Platform\Windows\TextBoxExtensions.cs(152,22): error RS0016: Symbol 'UpdateIsSpellCheckEnabled' is not part of the declared API [D:\a\_work\1\s\src\Core\src\Core.csproj]

@Redth will we need to bump this to net7 ? Other option is doing a 6.1.0

@jsuarezruiz jsuarezruiz added this to the .NET 7 milestone Jun 2, 2022
@jsuarezruiz
Copy link
Contributor Author

Added the .NET 7 milestone.

@rmarinho
Copy link
Member

rmarinho commented Jun 8, 2022

@jsuarezruiz can you add this to the API ?

@jsuarezruiz jsuarezruiz mentioned this pull request Jul 7, 2022
Closed
@rmarinho
Copy link
Member

rmarinho commented Sep 2, 2022

@jsuarezruiz can you rebase this one ? i might have screwed it up

@jsuarezruiz
Copy link
Contributor Author

To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR is not included in the next release so I close it for now. I will reopen it and adapt to changes later.

@jsuarezruiz jsuarezruiz closed this Nov 3, 2022
@mattleibow mattleibow reopened this Mar 20, 2023
@ghost
Copy link

ghost commented Mar 20, 2023

🚨 API change(s) detected @davidbritch FYI

@mattleibow mattleibow self-assigned this Mar 20, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

mattleibow
mattleibow reviewed Mar 21, 2023
View reviewed changes
src/Core/src/Platform/Windows/TextBoxExtensions.cs
@@ -154,6 +154,11 @@ public static void UpdateIsTextPredictionEnabled(this TextBox textBox, ITextInpu
textBox.UpdateInputScope(textInput);
}

public static void UpdateIsSpellCheckEnabled(this TextBox textBox, ITextInput textInput)
{
textBox.UpdateInputScope(textInput);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that this method does not set the spell check or the text prediction outside of a custom keyboard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using a custom keyboard, seems to be setting the text prediction here https://github.com/dotnet/maui/blob/main/src/Core/src/Platform/Windows/TextBoxExtensions.cs#L171

@rmarinho rmarinho enabled auto-merge (squash) March 22, 2023 13:55
mandel-macaque
mandel-macaque requested changes Mar 22, 2023
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but I think using HasFlag will make the coder ore readable and accessible to more jr devs.

src/Core/src/Platform/Android/EditTextExtensions.cs Outdated Show resolved Hide resolved
src/Core/src/Platform/Android/EditTextExtensions.cs Outdated Show resolved Hide resolved
@rmarinho rmarinho merged commit 96dbc45 into main Mar 22, 2023
@rmarinho rmarinho deleted the entry-isspellcheckenabled branch March 22, 2023 20:19
PureWeen added a commit that referenced this pull request Mar 22, 2023
@PureWeen
Revert "Implement Entry IsSpellCheckEnabled property (#7442)"
4fb8495 
This reverts commit 96dbc45.
@mattleibow
Copy link
Member

This was reverted in #14147

PureWeen added a commit that referenced this pull request Mar 23, 2023
@PureWeen
Revert "Implement Entry IsSpellCheckEnabled property (#7442)" (#14147)
13fabf5 
This reverts commit 96dbc45.
@samhouts samhouts modified the milestones: .NET 8 Planning, .NET 8 Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@rmarinho rmarinho rmarinho approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Assignees

@mattleibow mattleibow

Labels
area-controls-entry Entry fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! needs-breaking-change-doc-created t/breaking 💥
Projects
None yet
Milestone
.NET 8 + Servicing
Development

Successfully merging this pull request may close these issues.
6 participants
@jsuarezruiz @rmarinho @mattleibow @mandel-macaque @Eilon @samhouts